abstractdog commented on code in PR #4265:
URL: https://github.com/apache/hive/pull/4265#discussion_r1189526793
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/GenericColumnVectorProducer.java:
##########
@@ -220,6 +220,9 @@ public static List<TypeDescription>
setTypeBuilderFromSchema(
case TIMESTAMP:
type.setKind(OrcProto.Type.Kind.TIMESTAMP);
break;
+ case TIMESTAMP_INSTANT:
+ type.setKind(Type.Kind.TIMESTAMP_INSTANT);
Review Comment:
is this OrcProto.Type.Kind? if so, use it with the same convention as in
other branches of this switch case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]