InvisibleProgrammer commented on PR #4265: URL: https://github.com/apache/hive/pull/4265#issuecomment-1541624134
I have some extra thoughts about the tests: There are two changes in the code: I think one for generic execution and one for vectorised. But I think the test only tests one of them. And the test tests a lot of column types. But only the local timestamp column is affected on the change. I don't remember to the exact location but I think I saw some test that involves all column types. I would suggest creating (or finding an existing) vectorised test as well and also check if is there an existing checking all type of columns like test to extend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
