deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190929783


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, 
String tableName, Conte
 
         conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
     }
+
+    public static boolean isWriteOperation(Configuration conf, String 
tableName) {

Review Comment:
   is this they way we try to identify operation type, it looks not very 
straitforward



##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, 
String tableName, Conte
 
         conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
     }
+
+    public static boolean isWriteOperation(Configuration conf, String 
tableName) {

Review Comment:
   is this they way we try to identify operation type? it looks not very 
straightforward



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to