InvisibleProgrammer commented on code in PR #4328:
URL: https://github.com/apache/hive/pull/4328#discussion_r1196289477
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -117,11 +117,11 @@ public void testTimeout() throws Exception {
@Test
public void testResetTimeout() throws Exception {
- HMSHandler.testTimeoutValue = 250;
String dbName = "db";
// no timeout before reset
client.dropDatabase(dbName, true, true);
+ HMSHandler.testTimeoutValue = 250;
Review Comment:
The setup method of the test enables timeout. What about playing with the
timeout values, just disabling timeout at the beginning of the test case and
re-enable it after the drop database command?
And also, I wonder why the test `testNoTimeout` is not flaky. It works with
the same timeout value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
