deniskuzZ commented on code in PR #4346:
URL: https://github.com/apache/hive/pull/4346#discussion_r1205236787
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/show/ShowPartitionsOperation.java:
##########
@@ -54,12 +55,17 @@ public ShowPartitionsOperation(DDLOperationContext context,
ShowPartitionsDesc d
@Override
public int execute() throws HiveException {
Table tbl = context.getDb().getTable(desc.getTabName());
- if (!tbl.isPartitioned()) {
- throw new HiveException(ErrorMsg.TABLE_NOT_PARTITIONED,
desc.getTabName());
+ boolean isIcebergTable = isIcebergTable(tbl);
+ if (!(tbl.isPartitioned() || isIcebergTable)) {
+ throw new HiveException(ErrorMsg.TABLE_NOT_PARTITIONED,
desc.getTabName());
Review Comment:
this block is to handle cases when you call `show partitions` on
non-partitioned table. no need to protect if there is no partition support,
especially when you added the default impl for `showPartitions` in storage
handler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
