zhangbutao commented on code in PR #4292:
URL: https://github.com/apache/hive/pull/4292#discussion_r1208405219
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -542,14 +542,18 @@ default boolean isTimeTravelAllowed() {
return false;
}
- default boolean isMetadataTableSupported() {
+ default boolean isTableIdentifierSupported() {
return false;
}
default boolean isValidMetadataTable(String metaTableName) {
return false;
}
+ default boolean isValidBranch(org.apache.hadoop.hive.metastore.api.Table
hmsTable, String branchName) {
Review Comment:
I removed this method `isValidBranch` and added a new method
`HiveStorageHandler::checkAndSetTableMetaRef` which can check and set
tableMetaRef(metadata, branch, tag), and this can make `Hive::getTable` of `ql
` module more clean as the tableMetaRef is specific to iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
