saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1210852419
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1360,19 +1384,49 @@ public void create_database(final Database db)
}
Deadline.checkTimeout();
}
+ Database db = new Database(createDatabaseRequest.getDatabaseName(),
createDatabaseRequest.getDescription(),
+ createDatabaseRequest.getLocationUri()
,createDatabaseRequest.getParameters());
+ if (createDatabaseRequest.isSetPrivileges()) {
+ db.setPrivileges(createDatabaseRequest.getPrivileges());
+ }
+ if (createDatabaseRequest.isSetOwnerName()) {
+ db.setOwnerName(createDatabaseRequest.getOwnerName());
+ }
+ if (createDatabaseRequest.isSetOwnerType()) {
+ db.setOwnerType(createDatabaseRequest.getOwnerType());
+ }
+ db.setCatalogName(createDatabaseRequest.getCatalogName());
+ if (createDatabaseRequest.isSetCreateTime()) {
+ db.setCreateTime(createDatabaseRequest.getCreateTime());
+ }
+ if (createDatabaseRequest.isSetManagedLocationUri()) {
+
db.setManagedLocationUri(createDatabaseRequest.getManagedLocationUri());
+ }
+ if (createDatabaseRequest.isSetType()) {
+ db.setType(createDatabaseRequest.getType());
+ }
+ if (createDatabaseRequest.isSetDataConnectorName()) {
+ db.setConnector_name(createDatabaseRequest.getDataConnectorName());
+ }
+ if (createDatabaseRequest.isSetRemote_dbname()) {
+ db.setRemote_dbname(createDatabaseRequest.getRemote_dbname());
+ }
create_database_core(getMS(), db);
+ createDatabaseRequest.setLocationUri(db.getLocationUri());
Review Comment:
The same reasoning I gave for modification of `db` object after
create_database_req()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
