zhangbutao commented on PR #4341: URL: https://github.com/apache/hive/pull/4341#issuecomment-1569674644
> I and @deniskuzZ had a discussion about this last week and we aren't sure/convinced that if in any case the iceberg table should bother the managed warehouse location. > > I would rather say, we figure out this table can go to managed WH location and in that case in the hooks we make sure it doesn't go to Managed WH location but go to External WH location. > > Iceberg Table isn't a Hive managed table, so it shouldn't go to Managed WH location. @ayushtkn If we reach an agreement that no matter what the value of `METASTORE_METADATA_TRANSFORMER_CLASS` it is , the iceberg table shoud go to External WH location. We can simply set the iceberg table type to `EXTERNAL` type in `HiveIcebergMetaHook::preCreateTable`, so the iceberg location will always go to the External WH location and then `HMSHandler::create_table` also will not create a redundant&dangling managed location **_(if `METASTORE_METADATA_TRANSFORMER_CLASS` is empty)_.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
