dengzhhu653 commented on code in PR #4331:
URL: https://github.com/apache/hive/pull/4331#discussion_r1212455859
##########
service/src/test/org/apache/hive/service/auth/TestAuthType.java:
##########
@@ -75,10 +79,40 @@ private void
testOnePasswordAuthWithSAML(HiveAuthConstants.AuthTypes type) throw
Assert.assertFalse(authType.isEnabled(disabledType));
}
Assert.assertEquals(type.getAuthName(),
authType.getPasswordBasedAuthStr());
+
+ verify("SAML," + type.getAuthName(), HiveServer2TransportMode.binary,
true);
+ verify("SAML," + type.getAuthName(), HiveServer2TransportMode.all, true);
Review Comment:
In all mode, HS2 will start both binary and http thrift service, and
currently the only property: hive.server2.authentication works for both modes,
but the binary mode doesn't support JWT and SAML yet, so in all mode, these
haven't been supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
