rkirtir commented on code in PR #4288:
URL: https://github.com/apache/hive/pull/4288#discussion_r1214187317


##########
ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java:
##########
@@ -231,6 +234,51 @@ public int persistColumnStats(Hive db, Table tbl) throws 
HiveException, MetaExce
   @Override
   public void setDpPartSpecs(Collection<Partition> dpPartSpecs) {
   }
+  
+  private boolean isExistsNewerCommittedWriteId(){
+    return false;
+  }
+
+  public static boolean canSkipStatsGeneration(String dbName, String tblName, 
String partName,

Review Comment:
   seems this is  one of the utility methods, can we consider moving it to 
StatsUtils.java? we need to add test as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to