deniskuzZ commented on code in PR #4313:
URL: https://github.com/apache/hive/pull/4313#discussion_r1214271699
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/AbortedTxnCleaner.java:
##########
@@ -149,10 +157,20 @@ private void abortCleanUsingAcidDir(CompactionInfo info,
String location, long m
boolean success = cleanAndVerifyObsoleteDirectories(info, location,
validWriteIdList, table);
if (success || CompactorUtil.isDynPartAbort(table, info.partName)) {
- txnHandler.markCleaned(info, false);
+ txnHandler.markCleaned(info, true);
} else {
LOG.warn("Leaving aborted entry {} in TXN_COMPONENTS table.", info);
}
}
+
+ private void handleCleanerAttemptFailure(AbortTxnRequestInfo info) throws
MetaException {
+ long defaultRetention = getTimeVar(conf,
HIVE_COMPACTOR_CLEANER_RETRY_RETENTION_TIME, TimeUnit.MILLISECONDS);
+ int cleanAttempts = 0;
+ if (info.retryRetention > 0) {
+ cleanAttempts = (int)(Math.log(info.retryRetention / defaultRetention) /
Math.log(2)) + 1;
+ }
+ info.retryRetention = (long)Math.pow(2, cleanAttempts) * defaultRetention;
Review Comment:
also. where is backoff here? interval stays the same = 2* defaultRetention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
