mdayakar commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1217702875
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean
execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
Can you test a scenario like in HPL/SQL procedure/function you can use any
Hive built-in function and check whether it works or not. Because
[here](https://github.com/apache/hive/pull/4330/files#diff-7f870ba54791ec47f97a12f0b100d31a26527e5434a304edd61cb63ef9fb4596L108)
earlier they were checking like if _functionDefinition_ null then they treat
it as a built-in function and execute. So just once check this scenario, if it
works then its fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
