deniskuzZ commented on code in PR #4391: URL: https://github.com/apache/hive/pull/4391#discussion_r1221590658
########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDecimal.java: ########## @@ -66,6 +67,10 @@ protected void func(DecimalColumnVector outputColVector, BytesColumnVector input } } + protected void setOutputColumnVectorValue(ColumnVector outputColVector, int i, String s) { + ((DecimalColumnVector) outputColVector).set(i, HiveDecimal.create(s)); Review Comment: `set` method is different for `DecimalColumnVector` and `Decimal64ColumnVector`, unfortunately, I can't use parametrized type as `createVectorExpression` doesn't support generics -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org