okumin commented on code in PR #4404:
URL: https://github.com/apache/hive/pull/4404#discussion_r1225853705
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java:
##########
@@ -51,19 +53,22 @@ public TezEdgeProperty(HiveConf hiveConf, EdgeType edgeType,
}
public TezEdgeProperty(HiveConf hiveConf, EdgeType edgeType, boolean
isAutoReduce,
- boolean isSlowStart, int minReducer, int maxReducer, long
bytesPerReducer) {
+ boolean isSlowStart, int minReducer, int maxReducer, long
bytesPerReducer,
+ float minSrcFraction, float maxSrcFraction) {
this(hiveConf, edgeType, -1);
- setAutoReduce(hiveConf, isAutoReduce, minReducer, maxReducer,
bytesPerReducer);
+ setAutoReduce(hiveConf, isAutoReduce, minReducer, maxReducer,
bytesPerReducer, minSrcFraction, maxSrcFraction);
this.isSlowStart = isSlowStart;
}
public void setAutoReduce(HiveConf hiveConf, boolean isAutoReduce, int
minReducer,
- int maxReducer, long bytesPerReducer) {
+ int maxReducer, long bytesPerReducer, float minSrcFraction, float
maxSrcFraction) {
this.hiveConf = hiveConf;
this.minReducer = minReducer;
this.maxReducer = maxReducer;
this.isAutoReduce = isAutoReduce;
this.inputSizePerReducer = bytesPerReducer;
+ this.minSrcFraction = minSrcFraction;
+ this.maxSrcFraction = maxSrcFraction;
Review Comment:
I think [the first
commit](https://github.com/apache/hive/pull/4404/commits/c87b4ca6652dffc3cc150e54c793477108d8a74f)
is the simplest.
However, Gopal suggested I should move to the current style while the
previous PR is open.
https://issues.apache.org/jira/browse/HIVE-24485?focusedCommentId=17278522&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17278522
I personally don't have very strong opinions about how to support the params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
