zhangbutao opened a new pull request, #4408:
URL: https://github.com/apache/hive/pull/4408
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In `data/conf` module, `hive-site.xml` is used to qtest&test. It keeps many
invalid properties, and if you run test in IDE, you will see lots lof `WARN`:
```
2023-06-12T01:28:18,074 WARN [main] conf.HiveConf: HiveConf of name
hive.mapjoin.max.gc.time.percentage does not exist
2023-06-12T01:28:18,074 WARN [main] conf.HiveConf: HiveConf of name
hive.llap.io.cache.orc.size does not exist
2023-06-12T01:28:18,075 WARN [main] conf.HiveConf: HiveConf of name
hive.dummyparam.test.server.specific.config.override does not exist
2023-06-12T01:28:18,075 WARN [main] conf.HiveConf: HiveConf of name
hive.metastore.metadb.dir does not exist
2023-06-12T01:28:18,075 WARN [main] conf.HiveConf: HiveConf of name
hive.llap.io.cache.orc.alloc.min does not exist
2023-06-12T01:28:18,075 WARN [main] conf.HiveConf: HiveConf of name
hive.dummyparam.test.server.specific.config.hivesite does not exist
2023-06-12T01:28:18,075 WARN [main] conf.HiveConf: HiveConf of name
hive.llap.io.cache.orc.alloc.max does not exist
2023-06-12T01:28:18,075 WARN [main] conf.HiveConf: HiveConf of name
hive.metastore.client.cache.maxSize does not exist
2023-06-12T01:28:18,076 WARN [main] conf.HiveConf: HiveConf of name
hive.dummyparam.test.server.specific.config.metastoresite does not exist
2023-06-12T01:28:18,076 WARN [main] conf.HiveConf: HiveConf of name
hive.metastore.client.cache.recordStats does not exist
2023-06-12T01:28:18,076 WARN [main] conf.HiveConf: HiveConf of name
hive.llap.io.cache.orc.arena.size does not exist
2023-06-12T01:28:18,076 WARN [main] conf.HiveConf: HiveConf of name
hive.stats.key.prefix.reserve.length does not exist
```
**I have traced the life cycle of these invalid properties:**
`hive.mapjoin.max.gc.time.percentage`
Introduced by HIVE-17684, and removed by HIVE-26134.
```
hive.llap.io.cache.orc.size
hive.llap.io.cache.orc.alloc.min
hive.llap.io.cache.orc.alloc.max
```
Introduced by HIVE-11908, and removed by HIVE-12597.
```
hive.dummyparam.test.server.specific.config.override
hive.dummyparam.test.server.specific.config.hivesite
hive.dummyparam.test.server.specific.config.metastoresite
```
Introduced by HIVE-7342, although the three properties do not exist in
HiveConf, it is used by
`org.apache.hadoop.hive.metastore.TestServerSpecificConfig`. So Let's keep it
as it is.
`hive.metastore.metadb.dir`
Introduced by HADOOP-3601, and removed by HIVE-143 & HIVE-1897.
```
hive.metastore.client.cache.maxSize
hive.metastore.client.cache.recordStats
```
Introduced by HIVE-23949, and removed by HIVE-24202.
`hive.llap.io.cache.orc.arena.size`
Introduced by HIVE-11908, and removed by HIVE-12171.
`hive.stats.key.prefix.reserve.length`
Introduced by HIVE-6229, and removed by HIVE-12411.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
I have searched all `hive-site.xml` to ensure these invalid properties were
cleaned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
