deniskuzZ commented on code in PR #4392: URL: https://github.com/apache/hive/pull/4392#discussion_r1226522740
########## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ########## @@ -304,6 +305,22 @@ default boolean canComputeQueryUsingStats(org.apache.hadoop.hive.ql.metadata.Tab default StorageFormatDescriptor getStorageFormatDescriptor(Table table) throws SemanticException { return null; } + + /** + * Checks whether the table supports appending data files to the table. + * @param table the table + * @return true if the table can append files directly to the table + * @throws SemanticException in case of any error. + */ + default boolean supportsAppendData(Table table) throws SemanticException { + throw new SemanticException(ErrorMsg.LOAD_INTO_NON_NATIVE.getMsg()); Review Comment: should we return `false` here otherwise i don't see why we need this method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org