deniskuzZ commented on code in PR #4415:
URL: https://github.com/apache/hive/pull/4415#discussion_r1231311220
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java:
##########
@@ -122,6 +122,7 @@ public class VectorizedOrcInputFormat extends
FileInputFormat<NullWritable, Vect
public boolean next(NullWritable key, VectorizedRowBatch value) throws
IOException {
try {
+ value.reset();
Review Comment:
````
value.reset();
// Check and update partition cols if necessary. Ideally, this
should be done
// in CreateValue as the partition is constant per split. But since
Hive uses
// CombineHiveRecordReader and
// as this does not call CreateValue for each new RecordReader it
creates, this check is
// required in next()
if (addPartitionCols) {
if (partitionValues != null) {
rbCtx.addPartitionColsToBatch(value, partitionValues);
}
addPartitionCols = false;
}
try {
if (!reader.nextBatch(value)) {
return false;
}
} catch (Exception e) {
throw new RuntimeException(e);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
