difin commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1232756922
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -546,9 +548,17 @@ public static void
updateTableStatsForCreateTable(Warehouse wh, Database db, Tab
}
}
- if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.STATS_AUTO_GATHER)) {
+ boolean isIcebergTable = Optional.ofNullable(tbl.getParameters())
+ .orElse(Collections.emptyMap())
+ .getOrDefault(TABLE_TYPE_PROP, "undefined")
+ .equals(ICEBERG_TABLE_TYPE_VALUE);
+
+ if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.STATS_AUTO_GATHER) && !isIcebergTable) {
Review Comment:
_I think we can put StatsSetupConst.DO_NOT_UPDATE_STATS=true into table's
parameters at HiveIcebergMetaHook#preCreateTable_: This won't work for the
following scenario: let's suppose in hive config the stats source is Iceberg
and you create an Iceberg table and add a parameter to the table
'DO_NOT_UPDATE_STATS=true'. Then in hive config you change stats source to
Metastore. Stats won't be gathered for this table because of the table's
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
