deniskuzZ commented on code in PR #4291:
URL: https://github.com/apache/hive/pull/4291#discussion_r1235030041
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -176,11 +180,10 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
CommitStatus commitStatus = CommitStatus.FAILURE;
boolean updateHiveTable = false;
- HiveCommitLock commitLock = null;
+ HiveLock lock = lockObject(metadata);
Review Comment:
are we missing `Core: Avoid creating new metadata file on registerTable
(#6591)`here?
````
boolean newTable = base == null;
String newMetadataLocation = writeNewMetadataIfRequired(newTable,
metadata);
````
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -176,11 +180,10 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
CommitStatus commitStatus = CommitStatus.FAILURE;
boolean updateHiveTable = false;
- HiveCommitLock commitLock = null;
+ HiveLock lock = lockObject(metadata);
Review Comment:
are we missing `Core: Avoid creating new metadata file on registerTable
(#6591)`here?
````
boolean newTable = base == null;
String newMetadataLocation = writeNewMetadataIfRequired(newTable, metadata);
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
