SourabhBadhya commented on code in PR #4291:
URL: https://github.com/apache/hive/pull/4291#discussion_r1235187827
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -364,7 +413,6 @@ private void setHmsTableParameters(String
newMetadataLocation, Table tbl, TableM
tbl.setParameters(parameters);
}
- @VisibleForTesting
Review Comment:
Why is this annotation removed? I see the same in upstream Iceberg code.
There are also many such instances in this file where the annotation is
removed but I am generalising all of them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
