kokila-19 commented on code in PR #4430:
URL: https://github.com/apache/hive/pull/4430#discussion_r1236475893
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -123,6 +122,9 @@ private Token<?>
getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
config.put(SaslConfigs.SASL_JAAS_CONFIG, jaasConfig);
LOG.debug("Jaas config for requesting kafka credentials: {}", jaasConfig);
+ Configuration copy = new Configuration(conf);
Review Comment:
This variable name could be changed. Copy is too generic, ex: config,
copyconfig or tableconfig.
##########
kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplier.java:
##########
@@ -114,7 +108,12 @@ private Token<?>
getKafkaDelegationTokenForBrokers(Configuration conf, TableDesc
Properties config = new Properties();
Review Comment:
In reference to refactoring variable name of copy in line no. 125 ., I think
this name can be changed to **props or properties**. Improves code readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
