InvisibleProgrammer commented on code in PR #4291:
URL: https://github.com/apache/hive/pull/4291#discussion_r1236958734


##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -364,7 +413,6 @@ private void setHmsTableParameters(String 
newMetadataLocation, Table tbl, TableM
     tbl.setParameters(parameters);
   }
 
-  @VisibleForTesting

Review Comment:
   It was a mistake taken at porting the Hive: Refactor commit lock mechanism 
from HiveTableOperations change. I fixed it. 
   
   Thank you for finding this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to