dengzhhu653 commented on PR #4257: URL: https://github.com/apache/hive/pull/4257#issuecomment-1602576178
> > > @dengzhhu653, do you have any concerns with the current approach? > > > > > > I'm +1 on the idea of removing test codes from main routine. Rather than defining a template method, I'd like to introduce a hook for this purpose, unless we would introduce complex strategies around the `method.invoke(proxy, args)` in the future. > > I think, regardless if we introduce new custom strategies, the current patch makes the code more readable and extensible/flexible. The code itself looks fine to me, though I'm +0 on the factory approach, if we think the benefit wins the complexity and maintenance, I'm fine with the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
