simhadri-g commented on code in PR #4431:
URL: https://github.com/apache/hive/pull/4431#discussion_r1239739493


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -414,7 +416,7 @@ public boolean 
setColStatistics(org.apache.hadoop.hive.ql.metadata.Table hmsTabl
       List<ColumnStatistics> colStats) {
     Table tbl = IcebergTableUtil.getTable(conf, hmsTable.getTTable());
     String snapshotId = String.format("%s-STATS-%d", tbl.name(), 
tbl.currentSnapshot().snapshotId());
-    invalidateStats(getStatsPath(tbl));
+    checkAndMergeOrInvalidateStats(colStats.get(0), hmsTable);

Review Comment:
   For now, it will be size one implying all the column stats are stored as a 
single blob. 
   But in the next PR when we implement retrieving stats for particular columns 
this will be modified to store multiple blobs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to