okumin opened a new pull request, #4451: URL: https://github.com/apache/hive/pull/4451
### What changes were proposed in this pull request? This PR would just format `ParseUtils.java`. https://issues.apache.org/jira/browse/HIVE-22618 I recommend reviewers take a look at the diff of this PR via the following URL. https://github.com/apache/hive/compare/master...okumin:HIVE-22618-checkstyle?w=1 ### Why are the changes needed? Indentations of this file are totally broken and I felt it is hard to modify the file while working on another issue. I'd say we have no strong reasons to merge this one. I just created it because I hope other PRs are unlikely to conflict with this change now since it is not often updated recently. ### Does this PR introduce _any_ user-facing change? No ### Is the change a dependency upgrade? No ### How was this patch tested? These are the original checkstyle report. ``` root@fcc249b8c79d:~/hive# mvn -pl ql checkstyle:check -Dcheckstyle.consoleOutput=true | grep 'parse/ParseUtils.java' /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:227:13: warning: '(' is followed by whitespace. /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:227:25: warning: ')' is preceded with whitespace. /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:228:15: warning: '(' is followed by whitespace. /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:228:39: warning: ')' is preceded with whitespace. /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:241: warning: 'if' child have incorrect indentation level 8, expected level should be 6. /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:242: warning: 'if rcurly' have incorrect indentation level 6, expected level should be 4. ... (too many violations) root@fcc249b8c79d:~/hive# root@fcc249b8c79d:~/hive# mvn -pl ql checkstyle:check -Dcheckstyle.consoleOutput=true | grep 'parse/TestParseUtils.java' /root/hive/ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java:123:75: warning: ',' is not followed by whitespace. /root/hive/ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java:129:75: warning: ',' is not followed by whitespace. /root/hive/ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java:136:75: warning: ',' is not followed by whitespace. /root/hive/ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java:142:75: warning: ',' is not followed by whitespace. root@fcc249b8c79d:~/hive# ``` This is the result after applying this change. I'm keeping the `TODO` ones since it looks intentional. ``` root@fcc249b8c79d:~/hive# mvn -pl ql checkstyle:check -Dcheckstyle.consoleOutput=true | grep 'parse/ParseUtils.java' /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:426: warning: Comment matches to-do format 'TODO:'. /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:460: warning: Comment matches to-do format 'TODO:'. /root/hive/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:488: warning: Comment matches to-do format 'TODO:'. root@fcc249b8c79d:~/hive# root@fcc249b8c79d:~/hive# mvn -pl ql checkstyle:check -Dcheckstyle.consoleOutput=true | grep 'parse/TestParseUtils.java' root@fcc249b8c79d:~/hive# ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
