SourabhBadhya commented on code in PR #4440:
URL: https://github.com/apache/hive/pull/4440#discussion_r1241749076
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java:
##########
@@ -218,10 +220,13 @@ public int persistColumnStats(Hive db, Table tbl) throws
HiveException, MetaExce
}
start = System. currentTimeMillis();
+ boolean success = false;
if (tbl != null && tbl.isNonNative() &&
tbl.getStorageHandler().canSetColStatistics(tbl)) {
- tbl.getStorageHandler().setColStatistics(tbl, colStats);
+ success = tbl.getStorageHandler().setColStatistics(tbl, colStats);
}
- db.setPartitionColumnStatistics(request);
+ success |= db.setPartitionColumnStatistics(request);
Review Comment:
Yes there are some sections where the table stats are picked from metastore
as well. I will retry #4397 once the stats related fixes are merged. That will
let us know the missing cases as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
