simhadri-g commented on code in PR #4431:
URL: https://github.com/apache/hive/pull/4431#discussion_r1243610580
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -266,7 +267,7 @@ default boolean canProvideBasicStatistics() {
* @return boolean
*/
default boolean setColStatistics(org.apache.hadoop.hive.ql.metadata.Table
table,
- List<ColumnStatistics> colStats) {
+ List<ColumnStatistics> colStats, ColumnStatsDesc columnStatisticsDesc) {
Review Comment:
It was an oversight, we will need to modify it. We will need the
columnStatisticsDesc for the next improvements as well (writing individual
blobs per column). Since it is not out in any of the hive releases yet would it
be ok to modify the signature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
