zhangbutao commented on code in PR #4372:
URL: https://github.com/apache/hive/pull/4372#discussion_r1251579882
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableMetaRefSpec.java:
##########
@@ -48,17 +57,17 @@ public String toString() {
.add("operationParams", operationParams).toString();
}
- public static class CreateBranchSpec {
+ public static class CreateMetaRefSpec {
Review Comment:
> in iceberg project, it's called SnapshotRef, MetaRef is too wide
Renamed MetaRef to SnapshotRef.
> could we create also builders for tag and branch similar to
SnapshotRef.tagBuilder(snapshotId).build();
Maybe i misunderstand what your meaning, and i think no need to create
builder like iceberg project.
`Builder `in iceberg SnapshotRef is used to create multiple constructor.
e.g. `SnapshotRef.tagBuilder(snapshotId).build()` is used to create a tag
without any properties(maxRefAgeMs, minSnapshotsToKeep),
`SnapshotRef.tagBuilder(1L).maxRefAgeMs(10L).build()` is used to create a tag
with property `maxRefAgeMs`.
But what we need here is just only one constructor with all
properties(maxRefAgeMs, minSnapshotsToKeep..), and pass these properties to the
final branch& tag creation stage,` IcebergBranchExec.java` &
`IcebergTagExec.java`, and set these properties when invoking iceberg native
api to create banch & tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
