wecharyu commented on code in PR #4447:
URL: https://github.com/apache/hive/pull/4447#discussion_r1257058536
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
##########
@@ -569,9 +553,16 @@ private void open() throws MetaException {
+ "Continuing without it.", e);
}
}
+ } catch (TTransportException e) {
+ tte = e;
+ if (LOG.isDebugEnabled()) {
Review Comment:
Agreed.
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
##########
@@ -569,9 +553,16 @@ private void open() throws MetaException {
+ "Continuing without it.", e);
}
}
+ } catch (TTransportException e) {
+ tte = e;
+ if (LOG.isDebugEnabled()) {
+ LOG.warn("Failed to connect to the MetaStore Server...", e);
Review Comment:
`isDebugEnabled` is used to determine if we need print the full exception, I
think it's OK to remove it because we'll print the full exception if the client
was not connencted finally,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
