SourabhBadhya commented on code in PR #4431:
URL: https://github.com/apache/hive/pull/4431#discussion_r1258376149


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -266,7 +267,7 @@ default boolean canProvideBasicStatistics() {
    * @return boolean
    */
   default boolean setColStatistics(org.apache.hadoop.hive.ql.metadata.Table 
table,
-      List<ColumnStatistics> colStats) {
+      List<ColumnStatistics> colStats, ColumnStatsDesc columnStatisticsDesc) {

Review Comment:
   > @SourabhBadhya, why do we need per column Merge result?
   @deniskuzZ If there is a query which does Alter table Change column datatype.
   
   The column stats for that given column written by the older snapshots is of 
a different type. Hence they cant be merged. But other columns can proceed with 
merging the column stats (at least this seems to be the current behaviour for 
native tables).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to