deniskuzZ commented on code in PR #4428:
URL: https://github.com/apache/hive/pull/4428#discussion_r1258395699
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -313,6 +312,34 @@ protected void doPost(HttpServletRequest request,
HttpServletResponse response)
}
}
+ boolean approveOnFilter(HttpServletRequest request, HttpServletResponse
response)
Review Comment:
should we rename to `doFilter` with void return type and function as arg?
log a warning if not pass, otherwise execute function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
