aturoczy commented on code in PR #4421:
URL: https://github.com/apache/hive/pull/4421#discussion_r1258775976
##########
ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java:
##########
@@ -740,18 +742,12 @@ public void testRevokeTimedOutWorkers() throws Exception {
public void testFindPotentialCompactions() throws Exception {
// Test that committing unlocks
long txnid = openTxn();
- LockComponent comp = new LockComponent(LockType.SHARED_WRITE, LockLevel.DB,
- "mydb");
- comp.setTablename("mytable");
- comp.setOperationType(DataOperationType.UPDATE);
- List<LockComponent> components = new ArrayList<LockComponent>(1);
- components.add(comp);
- comp = new LockComponent(LockType.SHARED_WRITE, LockLevel.DB,
- "mydb");
- comp.setTablename("yourtable");
- comp.setPartitionname("mypartition=myvalue");
- comp.setOperationType(DataOperationType.UPDATE);
- components.add(comp);
+
+ List<LockComponent> components = new ArrayList<>(1);
Review Comment:
Why do you need this 1 as initializer? Is this necessary? Especially there
are 2 items in the array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
