rtrivedi12 commented on PR #4304: URL: https://github.com/apache/hive/pull/4304#issuecomment-1634142160
> The PR/JIRA ticket reports that there is an error when using `DROP TABLE IF EXISTS` but there were no test failures before this change and there are no new tests added as part of the changes here which indicates that there may not be enough coverage. > > Test cases are also an implicit documentation of how things are supposed to work so it would be great if we could add a few. Is there any particular reason of why the PR does not add tests covering/reproducing the reported error? This error/behavior change with `drop table if exists` is observed only with Ranger for unauthorized user( After RANGER-3407). Hence, there were no test failures. I had a discussion with the Hive QE team and they mentioned that this is a gap with QE testing too as all the variations with `drop table if Exists` are run with full permissions on Ranger. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
