deniskuzZ commented on code in PR #4415: URL: https://github.com/apache/hive/pull/4415#discussion_r1265004847
########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java: ########## @@ -635,4 +638,15 @@ public final boolean isPartitionCol(int colNum) { return colNum >= dataColumnCount && colNum < rowColumnTypeInfos.length; } + /** + * Reset all columns other than Partition columns + * @param rowBatch VectorizedRowBatch to reset + */ + public final void resetVectorizedRowBatch(VectorizedRowBatch rowBatch) { Review Comment: @maswin, could you please move it to VectorizedBatchUtil class, and name simply reset ########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java: ########## @@ -635,4 +638,15 @@ public final boolean isPartitionCol(int colNum) { return colNum >= dataColumnCount && colNum < rowColumnTypeInfos.length; } + /** + * Reset all columns other than Partition columns + * @param rowBatch VectorizedRowBatch to reset + */ + public final void resetVectorizedRowBatch(VectorizedRowBatch rowBatch) { Review Comment: @maswin, could you please move it to VectorizedBatchUtil class, and name simply `reset` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org