wecharyu commented on code in PR #4480:
URL: https://github.com/apache/hive/pull/4480#discussion_r1266929941


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -4055,7 +4055,6 @@ public boolean equals(Object obj) {
   private List<Partition> add_partitions_core(final RawStore ms, String 
catName,
                                               String dbName, String tblName, 
List<Partition> parts, final boolean ifNotExists)
       throws TException {
-    logAndAudit("add_partitions");

Review Comment:
   The audit log is recorded in public `add_partitions_xxx` methods, so I think 
we do not need repeat it in this common function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to