ayushtkn commented on code in PR #4341:
URL: https://github.com/apache/hive/pull/4341#discussion_r1268145282
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -253,7 +253,8 @@ public String toString() {
ConfVars.PARTITION_NAME_WHITELIST_PATTERN,
ConfVars.CAPABILITY_CHECK,
ConfVars.DISALLOW_INCOMPATIBLE_COL_TYPE_CHANGES,
- ConfVars.EXPRESSION_PROXY_CLASS
+ ConfVars.EXPRESSION_PROXY_CLASS,
+ ConfVars.METASTORE_METADATA_TRANSFORMER_CLASS
Review Comment:
Can pass something as part of environment context, create_table_as_external
and post the metadata transformer is done processing, if the table doesn't have
external keyword we can put external in TBLPROPERTIES
```
if (transformer != null) {
tbl = transformer.transformCreateTable(tbl, processorCapabilities,
processorId);
}
Post this check:-
// check if table isn't exteral & has env context set
// -> If yes, and has create_always_as_external set to true then add
external in TBLPROPERTIES
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
