zabetak commented on code in PR #4476:
URL: https://github.com/apache/hive/pull/4476#discussion_r1268159491
##########
hplsql/src/main/java/org/apache/hive/hplsql/Utils.java:
##########
@@ -32,18 +32,22 @@ public static String unquoteString(String s) {
}
int len = s.length();
- StringBuilder s2 = new StringBuilder(len);
+ StringBuilder s2 = new StringBuilder(len);
+ boolean isEscape = true;
Review Comment:
The formatting appears off because there is a mix of tabs and spaces in
indentation. According to the projects [coding
conventions](https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions)
spaces should be used for indentation (not tabs) so the new code added in this
PR is correctly formatted. However, the old code is not (it includes both tabs
and spaces) and thus indentation appears broken.
To avoid this weird diff, I will exceptionally use the non-compliant tab +
space indentation in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
