InvisibleProgrammer commented on code in PR #3798:
URL: https://github.com/apache/hive/pull/3798#discussion_r1268531055
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java:
##########
@@ -129,6 +137,14 @@ public int execute() {
}
}
+ @NotNull
+ private void initializeReplLogger(AtlasReplInfo atlasReplInfo) {
+ if (this.replLogger == null){
+ this.replLogger = new AtlasDumpLogger(atlasReplInfo.getSrcDB(),
+ atlasReplInfo.getStagingDir().toString());
+ }
+ }
Review Comment:
@kgyrtkirk : It seems I can redo the original behaviour with upgrading
mockito from 3.x to 4.x.
The sad thing is that 4.x release contains a huge clean up and they removed
a lot of deprecated methods that we already use. I create a jira about
upgrading mockito to 4.x and I will continue this ticket after that.
Side note:
I've tried to upgrade mockito only in hive-exec but it is a tricky one and
actually, 3.x is automatically pulled from the parent pom (in our case, it is
our root pom.xml so I cannot do it in a module-by-module bases.
But also, it contains a lot of small changes and it will be way easier to
review it if I do it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
