difin commented on code in PR #4477:
URL: https://github.com/apache/hive/pull/4477#discussion_r1270977357
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -231,10 +231,17 @@ public static void
validateTableIsIceberg(org.apache.hadoop.hive.ql.metadata.Tab
}
public static boolean isIcebergTable(Table table) {
- return table.isNonNative() &&
- table.getStorageHandler().getType() == StorageHandlerTypes.ICEBERG;
+ return table.isNonNative() &&
+ ((table.getStorageHandler() != null &&
table.getStorageHandler().getType() == StorageHandlerTypes.ICEBERG) ||
+ isIcebergTableType(table.getTTable().getParameters()));
Review Comment:
Fixed @ rested on using MiniHS2Cluster for Iceberg and Hive ACID tables.
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -231,10 +231,17 @@ public static void
validateTableIsIceberg(org.apache.hadoop.hive.ql.metadata.Tab
}
public static boolean isIcebergTable(Table table) {
- return table.isNonNative() &&
- table.getStorageHandler().getType() == StorageHandlerTypes.ICEBERG;
+ return table.isNonNative() &&
+ ((table.getStorageHandler() != null &&
table.getStorageHandler().getType() == StorageHandlerTypes.ICEBERG) ||
+ isIcebergTableType(table.getTTable().getParameters()));
Review Comment:
Fixed @ retested on using MiniHS2Cluster for Iceberg and Hive ACID tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
