wangyum commented on PR #3066:
URL: https://github.com/apache/hive/pull/3066#issuecomment-1647875170

   @pan3793 It should throw `Could not find include file 
share/fb303/if/fb303.thrift`:
   ```
   root@e8c54f097cdf:/opensource/HIVE-25996# mvn -pl metastore -Pthriftif 
-DskipTests=true package -Dthrift.home=/usr/local
   [INFO] Scanning for projects...
   [INFO]                                                                       
  
   [INFO] 
------------------------------------------------------------------------
   [INFO] Building Hive Metastore 2.3.10-SNAPSHOT
   [INFO] 
------------------------------------------------------------------------
   [INFO] 
   [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-no-snapshots) @ 
hive-metastore ---
   [INFO] 
   [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-banned-dependencies) 
@ hive-metastore ---
   [INFO] 
   [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-property) @ 
hive-metastore ---
   [INFO] 
   [INFO] --- maven-antrun-plugin:1.7:run (generate-thrift-sources) @ 
hive-metastore ---
   [INFO] Executing tasks
   
   main:
      [delete] Deleting directory 
/opensource/HIVE-25996/metastore/src/gen/thrift
       [mkdir] Created dir: /opensource/HIVE-25996/metastore/src/gen/thrift
        [echo] Generating Thrift code for 
/opensource/HIVE-25996/metastore/if/hive_metastore.thrift
        [exec] 
[ERROR:/opensource/HIVE-25996/metastore/if/hive_metastore.thrift:1033] (last 
token was 'fb303.FacebookService')
        [exec] Service "fb303.FacebookService" has not been defined.
        [exec] 
[WARNING:/opensource/HIVE-25996/metastore/if/hive_metastore.thrift:25] Could 
not find include file share/fb303/if/fb303.thrift
        [exec] 
   [INFO] 
------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] 
------------------------------------------------------------------------
   [INFO] Total time: 1.199 s
   [INFO] Finished at: 2023-07-24T12:59:31+00:00
   [INFO] Final Memory: 33M/362M
   [INFO] 
------------------------------------------------------------------------
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-antrun-plugin:1.7:run (generate-thrift-sources) 
on project hive-metastore: An Ant BuildException has occured: The following 
error occurred while executing this line:
   [ERROR] /opensource/HIVE-25996/metastore/target/antrun/build-main.xml:15: 
exec returned: 1
   [ERROR] around Ant part ...<for param="thrift.file">... @ 9:28 in 
/opensource/HIVE-25996/metastore/target/antrun/build-main.xml
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please 
read the following articles:
   [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
   ```
   It works if add 
[fb303.thrift](https://github.com/apache/thrift/blob/master/contrib/fb303/if/fb303.thrift)
 to `share/fb303/if/`:
   ```
   root@e8c54f097cdf:/opensource/HIVE-25996# mvn -pl metastore -Pthriftif 
-DskipTests=true package -Dthrift.home=/usr/local
   [INFO] Scanning for projects...
   [INFO]                                                                       
  
   [INFO] 
------------------------------------------------------------------------
   [INFO] Building Hive Metastore 2.3.10-SNAPSHOT
   [INFO] 
------------------------------------------------------------------------
   [INFO] 
   [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-no-snapshots) @ 
hive-metastore ---
   [INFO] 
   [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-banned-dependencies) 
@ hive-metastore ---
   [INFO] 
   [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-property) @ 
hive-metastore ---
   [INFO] 
   [INFO] --- maven-antrun-plugin:1.7:run (generate-thrift-sources) @ 
hive-metastore ---
   [INFO] Executing tasks
   
   main:
      [delete] Deleting directory 
/opensource/HIVE-25996/metastore/src/gen/thrift
       [mkdir] Created dir: /opensource/HIVE-25996/metastore/src/gen/thrift
        [echo] Generating Thrift code for 
/opensource/HIVE-25996/metastore/if/hive_metastore.thrift
   [INFO] Executed tasks
   [INFO] 
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to