vikramahuja1001 commented on code in PR #4501:
URL: https://github.com/apache/hive/pull/4501#discussion_r1275491091


##########
ql/src/test/results/clientpositive/llap/temp_table_add_part_multiple.q.out:
##########
@@ -115,5 +115,5 @@ POSTHOOK: Input: default@add_part_test_n1_temp@ds=2010-04-01
 #### A masked pattern was here ####
 100    100     2010-01-01
 200    200     2010-02-01
-500    400     2010-04-01
 400    300     2010-03-01
+500    400     2010-04-01

Review Comment:
   This change is only applicable for Temporary tables. Previously in the case 
of older getPartitions API, we are directly fetching the partitions from the 
PartitionTree(check ` SessionHiveMetaStoreClient. listPartitions(String 
catName, String dbName, String tblName, int maxParts)` ). But in the case of 
new API, we first fetch the partitionNames from the PartitionTree(check ` 
SessionHiveMetaStoreClient.listPartitionNames(String catName, String dbName, 
String tblName,
         int maxParts)` ). We then sort those partition names and then create 
batches based on that and fire multiple calls to the HMS to fetch the subset of 
partitions. Since we are sorting the partitionNames we are essentially changing 
the order in which partitions are fetched and added in the list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to