deniskuzZ commented on code in PR #4520:
URL: https://github.com/apache/hive/pull/4520#discussion_r1278879699
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java:
##########
@@ -1352,7 +1371,8 @@ public static void
createMRWorkForMergingFiles(FileSinkOperator fsInput,
Task<MoveWork> mvTask = GenMapRedUtils.findMoveTaskForFsopOutput(mvTasks,
fsopPath, fsInputDesc.isMmTable(),
fsInputDesc.isDirectInsert(), fsInputDesc.getMoveTaskId(),
fsInputDesc.getAcidOperation());
ConditionalTask cndTsk = GenMapRedUtils.createCondTask(conf, currTask,
dummyMv, work,
- fsInputDesc.getMergeInputDirName(), finalName, mvTask, dependencyTask,
lineageState);
+ changeToTmpPath ?
Utilities.toTempPath(fsInputDesc.getMergeInputDirName()) :
fsInputDesc.getMergeInputDirName(),
Review Comment:
could you extract `changeToTmpPath ?
Utilities.toTempPath(fsInputDesc.getMergeInputDirName()) :
fsInputDesc.getMergeInputDirName()` logic to
`FileSinkDesc.getMergeInputDirName` by adding `changeToTempPath ` method
argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
