zhangbutao commented on code in PR #4510:
URL: https://github.com/apache/hive/pull/4510#discussion_r1282725353
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergBranchExec.java:
##########
@@ -63,4 +64,15 @@ public static void createBranch(Table table,
AlterTableSnapshotRefSpec.CreateSna
manageSnapshots.commit();
}
+
+ public static void dropBranch(Table table,
AlterTableSnapshotRefSpec.DropSnapshotRefSpec dropBranchSpec) {
+ String branchName = dropBranchSpec.getRefName();
+ Boolean ifExists = dropBranchSpec.getIfExists();
Review Comment:
Yes, fixed.
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java:
##########
@@ -141,6 +141,7 @@ public enum HiveOperationType {
ALTERTABLE_UPDATECOLUMNS,
ALTERTABLE_CREATEBRANCH,
ALTERTABLE_CREATETAG,
+ ALTERTABLE_DROPBRANCH,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
