dengzhhu653 commented on code in PR #4475:
URL: https://github.com/apache/hive/pull/4475#discussion_r1285362477
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/HiveDatabaseAccessor.java:
##########
@@ -56,4 +57,19 @@ protected String addLimitToQuery(String sql, int limit) {
}
return sql + " LIMIT " + limit;
}
+
+ @Override
+ protected List<String> getColNamesFromRS(ResultSet rs) throws Exception {
+ List<String> columnNames = super.getColNamesFromRS(rs);
+ return columnNames.stream()
+ .map(c -> {
+ int lastIndex = c.lastIndexOf(".");
+ return lastIndex == -1 ? c : c.substring(lastIndex + 1); })
+ .collect(Collectors.toList());
+ }
+
+ @Override
+ protected String getMetaDataQuery(String sql) {
+ return addLimitToQuery(sql, 0);
Review Comment:
I tried on MySQL and Postgres, `limit 0` works for them. I wasn't applying
the change in the base mainly because:
1. I couldn't figure out why it was on the original fix;
2. `limit 1` wouldn't introduce much overhead on these databases except Hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
