rtrivedi12 commented on code in PR #4572:
URL: https://github.com/apache/hive/pull/4572#discussion_r1289915173


##########
ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java:
##########
@@ -133,6 +133,22 @@ public void testB_CreateTable_unAuthorizedUser() throws 
Exception {
     }
   }
 
+  @Test
+  public void testI_CreateExternalTable_authorizedUser() throws Exception {
+    
UserGroupInformation.setLoginUser(UserGroupInformation.createRemoteUser(authorizedUser));
+    try {
+      Table table = new TableBuilder()
+              .setTableName(tblName)
+              .setType(TableType.EXTERNAL_TABLE.name())
+              .addCol("name", ColumnType.STRING_TYPE_NAME)
+              .setOwner(authorizedUser)
+              .build(conf);
+      hmsHandler.create_table(table);

Review Comment:
   Included this as we do not have any create external table test with 
authorization enabled. We can remove it as we have now added qtest creating an 
external table with the location specified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to