veghlaci05 commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1293060235
##########
ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java:
##########
@@ -742,12 +740,18 @@ public void testRevokeTimedOutWorkers() throws Exception {
public void testFindPotentialCompactions() throws Exception {
// Test that committing unlocks
long txnid = openTxn();
-
- List<LockComponent> components = new ArrayList<>();
-
- components.add(createLockComponent(LockType.SHARED_WRITE, LockLevel.DB,
"mydb", "mytable", null, DataOperationType.UPDATE));
- components.add(createLockComponent(LockType.SHARED_WRITE, LockLevel.DB,
"mydb", "yourtable", "mypartition=myvalue", DataOperationType.UPDATE));
-
+ LockComponent comp = new LockComponent(LockType.SHARED_WRITE, LockLevel.DB,
Review Comment:
This is a merge issue, I'll fix it.
##########
ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java:
##########
@@ -999,62 +1003,6 @@ public void testEnqueueTimeThroughLifeCycle() throws
Exception {
checkEnqueueTime(enqueueTime);
}
- @Test
- public void testFindPotentialCompactions_limitFetchSize() throws Exception {
Review Comment:
This is a merge issue, I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
