veghlaci05 commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1293079646
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -179,90 +93,12 @@ public Set<CompactionInfo> findPotentialCompactions(int
abortedThreshold, long a
@RetrySemantics.ReadOnly
public Set<CompactionInfo> findPotentialCompactions(int abortedThreshold,
long abortedTimeThreshold, long lastChecked) throws MetaException {
- Connection dbConn = null;
- Set<CompactionInfo> response = new HashSet<>();
- Statement stmt = null;
- ResultSet rs = null;
- try {
- try {
- dbConn = getDbConn(Connection.TRANSACTION_READ_COMMITTED,
connPoolCompaction);
- stmt = dbConn.createStatement();
-
- long startedAt = System.currentTimeMillis();
- long checkInterval = (lastChecked <= 0) ? lastChecked : (startedAt -
lastChecked + 500) / 1000;
-
- // Check for completed transactions
- final String s = dbProduct.addLimitClause(
- MetastoreConf.getIntVar(conf, ConfVars.COMPACTOR_FETCH_SIZE),
- "DISTINCT \"TC\".\"CTC_DATABASE\", \"TC\".\"CTC_TABLE\",
\"TC\".\"CTC_PARTITION\" " +
- "FROM \"COMPLETED_TXN_COMPONENTS\" \"TC\" " + (checkInterval > 0 ?
- "LEFT JOIN ( " +
- " SELECT \"C1\".* FROM \"COMPLETED_COMPACTIONS\" \"C1\" " +
- " INNER JOIN ( " +
- " SELECT MAX(\"CC_ID\") \"CC_ID\" FROM \"COMPLETED_COMPACTIONS\"
" +
- " GROUP BY \"CC_DATABASE\", \"CC_TABLE\", \"CC_PARTITION\"" +
- " ) \"C2\" " +
- " ON \"C1\".\"CC_ID\" = \"C2\".\"CC_ID\" " +
- " WHERE \"C1\".\"CC_STATE\" IN (" + quoteChar(DID_NOT_INITIATE) +
"," + quoteChar(FAILED_STATE) + ")" +
- ") \"C\" " +
- "ON \"TC\".\"CTC_DATABASE\" = \"C\".\"CC_DATABASE\" AND
\"TC\".\"CTC_TABLE\" = \"C\".\"CC_TABLE\" " +
- " AND (\"TC\".\"CTC_PARTITION\" = \"C\".\"CC_PARTITION\" OR
(\"TC\".\"CTC_PARTITION\" IS NULL AND \"C\".\"CC_PARTITION\" IS NULL)) " +
- "WHERE \"C\".\"CC_ID\" IS NOT NULL OR " +
isWithinCheckInterval("\"TC\".\"CTC_TIMESTAMP\"", checkInterval) : ""));
-
- LOG.debug("Going to execute query <{}>", s);
-
- rs = stmt.executeQuery(s);
- while (rs.next()) {
- CompactionInfo info = new CompactionInfo();
- info.dbname = rs.getString(1);
- info.tableName = rs.getString(2);
- info.partName = rs.getString(3);
- response.add(info);
- }
- rs.close();
-
- if (!MetastoreConf.getBoolVar(conf,
ConfVars.COMPACTOR_CLEAN_ABORTS_USING_CLEANER)) {
- // Check for aborted txns: number of aborted txns past threshold and
age of aborted txns
- // past time threshold
- boolean checkAbortedTimeThreshold = abortedTimeThreshold >= 0;
- String sCheckAborted = "SELECT \"TC_DATABASE\", \"TC_TABLE\",
\"TC_PARTITION\", " +
- "MIN(\"TXN_STARTED\"), COUNT(*) FROM \"TXNS\",
\"TXN_COMPONENTS\" " +
- " WHERE \"TXN_ID\" = \"TC_TXNID\" AND \"TXN_STATE\" = " +
TxnStatus.ABORTED + " " +
- "GROUP BY \"TC_DATABASE\", \"TC_TABLE\", \"TC_PARTITION\" " +
- (checkAbortedTimeThreshold ? "" : " HAVING COUNT(*) > " +
abortedThreshold);
-
- LOG.debug("Going to execute query <{}>", sCheckAborted);
- rs = stmt.executeQuery(sCheckAborted);
- long systemTime = System.currentTimeMillis();
- while (rs.next()) {
- boolean pastTimeThreshold =
- checkAbortedTimeThreshold && rs.getLong(4) +
abortedTimeThreshold < systemTime;
- int numAbortedTxns = rs.getInt(5);
- if (numAbortedTxns > abortedThreshold || pastTimeThreshold) {
- CompactionInfo info = new CompactionInfo();
- info.dbname = rs.getString(1);
- info.tableName = rs.getString(2);
- info.partName = rs.getString(3);
- info.tooManyAborts = numAbortedTxns > abortedThreshold;
- info.hasOldAbort = pastTimeThreshold;
- LOG.debug("Found potential compaction: {}", info);
- response.add(info);
- }
- }
- }
- } catch (SQLException e) {
- LOG.error(DB_FAILED_TO_CONNECT + e.getMessage());
- checkRetryable(e,
- "findPotentialCompactions(maxAborted:" + abortedThreshold
- + ", abortedTimeThreshold:" + abortedTimeThreshold + ")");
- } finally {
- close(rs, stmt, dbConn);
- }
- return response;
- }
- catch (RetryException e) {
- return findPotentialCompactions(abortedThreshold, abortedTimeThreshold,
lastChecked);
+ Set<CompactionInfo> candidates = new HashSet<>(new
CompactionCandidateHandler(lastChecked,
Review Comment:
I was already thinking in sth like that. The problem is that the parameters
are varying in every QueryHandler implementation, so it could be done only if
the parameters are passed as an Object array. I was also thinking of passing a
prepared SqlParameterSource, but some handlers are requiring other parameters,
like conf variables, or modifier flags, and those parameters are not used in
the SQL itself. So I decided to pass the parameters in the constructor, so the
differences are not affecting the interface method. If you have any other ideas
please share it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
