rkirtir commented on code in PR #4497:
URL: https://github.com/apache/hive/pull/4497#discussion_r1298133373


##########
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java:
##########
@@ -1584,69 +1510,39 @@ public void sqlInsertPartition() throws Exception {
 
     event = rsp.getEvents().get(12);
     assertEquals(firstEventId + 13, event.getEventId());
-    assertEquals(EventType.ADD_PARTITION.toString(), event.getEventType());
+    assertEquals(EventType.INSERT.toString(), event.getEventType());
 
     event = rsp.getEvents().get(13);
     assertEquals(firstEventId + 14, event.getEventId());
-    assertEquals(EventType.INSERT.toString(), event.getEventType());
-    // Parse the message field
-    verifyInsert(event, null, tblName);
+    assertEquals(EventType.ALTER_PARTITION.toString(), event.getEventType());

Review Comment:
   fixed. Inert in table with partition generates different events based on 
command used
    insert into table mytb partition (ds) values (2, 'today')- generates 1 
ALTER_PARTITION events
   insert into table mytb partition (ds = 'today') values (2) - generates 2 
ALTER_PARTITION events



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to