SourabhBadhya commented on code in PR #4571:
URL: https://github.com/apache/hive/pull/4571#discussion_r1299728658
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7906,6 +7945,10 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
if (!(destType == QBMetaData.DEST_DFS_FILE && qb.getIsQuery())
&& destinationTable != null &&
destinationTable.getStorageHandler() != null) {
try {
+ if (!updating(dest) && !deleting(dest)) {
+ input = genConversionSelectOperatorByAddPartition(dest, qb, input,
destinationTable.getDeserializer(),
+ destinationTable, partSpec);
+ }
input = genConversionSelectOperator(
dest, qb, input, tableDescriptor.getDeserializer(conf), dpCtx,
null, destinationTable);
Review Comment:
@kasakrisz My idea was to isolate the addition of partition column into the
operator with other cases where manipulation of select operator is necessary.
Do you think it should within the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
