scarlin-cloudera commented on code in PR #4442:
URL: https://github.com/apache/hive/pull/4442#discussion_r1306577506
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java:
##########
@@ -577,6 +588,77 @@ private QueryBlockInfo convertSource(RelNode r) throws
CalciteSemanticException
ast = ASTBuilder.subQuery(left, sqAlias);
s = new Schema((Union) r, sqAlias);
}
+ } else if (r instanceof HiveTableFunctionScan &&
+ !canOptimizeOutLateralView((HiveTableFunctionScan) r)) {
+ // In the case where the RelNode is a HiveTableFunctionScan, first we
check
+ // to see if we can't optimize out the lateral view operator. We can
optimize the
+ // operator out if only the udtf fields are grabbed out of the RelNode.
If any
+ // of the base table fields need to be grabbed out, then a 'join' needs
to be done
+ // and we need the lateral view.
+ //
+ // The structure of the AST in this "else if" branch will be:
Review Comment:
Changed the code a bit. Not sure if I can write up a test case for this,
but there are extensive q tests which cover all the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
